Skip to content

Create a first Maven 4 test case #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Create a first Maven 4 test case #2057

wants to merge 3 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Oct 18, 2025 •
edited
Loading

Overview

This PR adds a comprehensive Maven 4 test case to demonstrate that m2e currently does not support Maven 4 features and to provide a validation target for future Maven 4 support implementation.

What's Added

Maven4Test.java

A new JUnit test class in org.eclipse.m2e.core.tests with two test methods:

  • testMaven4BasicProject() - Attempts to import a Maven 4 multi-module project with subprojects
  • testMaven4ModelVersion() - Tests parsing of Maven 4.1.0 model version

These tests are expected to fail with the current m2e (which only supports Maven 3) and will pass once Maven 4 support is implemented. This serves two purposes:

  1. Documents that m2e does NOT currently support Maven 4
  2. Provides validation that Maven 4 support works when implemented

HelloMaven4 Test Project

A demonstration Maven 4 project in resources/projects/HelloMaven4/ that showcases real-world Maven 4 features:

Maven 4 Features Demonstrated:

  • ✅ Model version 4.1.0 - Uses <modelVersion>4.1.0</modelVersion> and the new xmlns="http://maven.apache.org/POM/4.1.0" namespace
  • ✅ Subprojects instead of modules - Parent POM uses <subprojects> element instead of <modules>
  • ✅ Inheritance of groupId and version - Child POMs omit <groupId> and <version> tags, inheriting them from the parent
  • ⏳ Better Java version handling - Uses maven.compiler.release property (partially demonstrated)

Project Structure:

HelloMaven4/
├── pom.xml (parent with Maven 4.1.0)
├── hello-core/ (library subproject)
│   ├── pom.xml
│   └── src/main/java/.../GreetingService.java
├── hello-app/ (application subproject)
│   ├── pom.xml
│   └── src/main/java/.../HelloWorldApp.java
└── README.md (comprehensive documentation)

The project includes:

  • A simple GreetingService library in hello-core
  • A HelloWorldApp application in hello-app that depends on hello-core
  • Complete README documenting all Maven 4 features used, references, and scope

Based On

This implementation follows the real-world Maven 4 usage from the jline3 project, as requested in the issue.

Goals

As outlined in the issue, this PR achieves:

  1. Shows that current m2e does NOT support Maven 4 - The tests will fail when run, documenting the gap
  2. Provides a validation target - As Maven 4 support is implemented, this test can be used to verify it works correctly and can be enhanced to test additional features

References

Fixes #ISSUE_NUMBER

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cbi.eclipse.org
    • Triggering command: curl -o org/fusesource/jansi/internal/native/Mac/arm64/libjansi.jnilib -F file=@org/fusesource/jansi/internal/native/Mac/arm64/libjansi.jnilib-tosign REDACTED (dns block)
    • Triggering command: curl -o org/fusesource/jansi/internal/native/Mac/x86/libjansi.jnilib -F file=@org/fusesource/jansi/internal/native/Mac/x86/libjansi.jnilib-tosign REDACTED (dns block)
    • Triggering command: curl -o org/fusesource/jansi/internal/native/Mac/x86_64/libjansi.jnilib -F file=@org/fusesource/jansi/internal/native/Mac/x86_64/libjansi.jnilib-tosign REDACTED (dns block)
  • repo.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/m2e-core/m2e-core org.codehaus.plexus.classworlds.launcher.Launcher clean compile -pl org.eclipse.m2e.core.tests -am (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Create a fist Maven 4 testcase</issue_title>
<issue_description>Currently m2e uses Maven 3 but Maven 4 is approaching soon https://lists.apache.org/thread/jnb3snhdm4b564gz8hbctp9rfk8fc67n and there is a lot of new feature to find.

Because of this we should take a first step and add a new JUnit test to m2e that uses a Maven 4 style project.

For this we should

  • add a new tescase Maven4Test to org.eclipse.m2e.core.tests
  • create a dummy Maven 4 project in resources/projects/HelloMaven4
  • this project should be based on https://github.com/jline/jline3 as an example for the use of maven 4 features (e.g. new model version, subprojects, inheritance of group and version) as a real world usage.
  • We should uses a "demo" namespace and we do not need that much code and details so a simple HelloWorld application would be sufficient but still use enough of the new feature
  • We should reference what new maven 4 features to be found here https://maven.apache.org/whatsnewinmaven4.html are used in the example and place a readme in the resources/projects/HelloMaven4 to describe the current coverage and scope
  • Make sure this compiles fine with the latest Preview 4.x release found here https://maven.apache.org/download.cgi

This has two goals here:

  1. We show that current m2e does NOT support Maven 4
  2. While we implement Maven 4 support we can use this as a proof it actually works and later can be enhanced if we discover more things that need to be implemented.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #2056

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Add initial Maven 4 testcase to m2e Create a first Maven 4 test case Oct 18, 2025
Copilot AI requested a review from laeubi October 18, 2025 12:37
Copilot finished work on behalf of laeubi October 18, 2025 12:37
@laeubi
Copy link
Member

laeubi commented Oct 18, 2025

Test case was included here:

@laeubi laeubi closed this Oct 18, 2025
@HannesWell HannesWell deleted the copilot/add-maven4-test-case branch October 19, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laeubi laeubi Awaiting requested review from laeubi

Assignees

@laeubi laeubi

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a first Maven 4 testcase

2 participants

@laeubi